Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
remove_hierarchical_links
toSTACObject
Links.is_hierarchical
I personally prefer the term "structural", but "hierarchical" was already in use so I stuck with that:
pystac/pystac/link.py
Lines 27 to 34 in a573835
Includes the first pytest fixture for the test cases. I went for a more descriptive catalog name (
label_catalog
) instead oftest_case_1
-- my thought is that it'll be nicer to depend on a well-named fixture rather than some arbitrary numbering scheme. I also followed @jsignell's recommendation and remove thetest_
prefix from some existing fixtures.PR Checklist:
pre-commit run --all-files
)scripts/test
)